Optimize some computation-intensive code #9721
Conversation
- Avoid recursions deeper than 10 - Avoid copying tail after last dropped element
replace filter by filterConserve if - the call is warm (called for more than 10% of source lines) - the filter predicate has a high chance of succeeding Avoid filter altogether if there's a faster alternative
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
test performance please |
|
performance test scheduled: 9 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9721/ to see the changes. Benchmarks is based on merging with master (1ab71c1) |
|
test performance please |
|
performance test scheduled: 8 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9721/ to see the changes. Benchmarks is based on merging with master (1ab71c1) |
|
This looks like a consistent win (~6%) for stdlib, and in the noise for the others. So it looks worthwhile to merge this. |
3 participants
No description provided.